From 50f17a5c72154263288547dec64a38d50592d9b1 Mon Sep 17 00:00:00 2001 From: Glyph Date: Wed, 7 Sep 2022 15:18:36 -0700 Subject: [PATCH 1/2] fix template typo --- .github/PULL_REQUEST_TEMPLATE | 2 +- src/twisted/newsfragments/11647.misc | 0 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 src/twisted/newsfragments/11647.misc diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index ceb881ad637..d709b3e98e8 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -15,7 +15,7 @@ Add mentions of things that are not covered here and are planed to be done in se This process applies to *all* pull requests - no matter how small. Have a look at [our developer documentation](https://docs.twisted.org/en/latest/core/development/dev-process.html) before submitting your Pull Request. -Below is a non-exaustive list (as a reminder): +Below is a non-exhaustive list (as a reminder): * The title of the PR should describe the changes and starts with the associated issue number, like “#1234 Brief description”. * A release notes news fragment file was create in src/twisted/newsfragments/ (see: [Release notes fragments docs.](https://docs.twisted.org/en/latest/core/development/dev-process.html#release-notes-management)) diff --git a/src/twisted/newsfragments/11647.misc b/src/twisted/newsfragments/11647.misc new file mode 100644 index 00000000000..e69de29bb2d From 524f83b594086ad047854754e6a8363f6e49924a Mon Sep 17 00:00:00 2001 From: Glyph Date: Wed, 7 Sep 2022 15:30:48 -0700 Subject: [PATCH 2/2] more polite message --- .github/PULL_REQUEST_TEMPLATE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index d709b3e98e8..54b2a1733f5 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -20,6 +20,6 @@ Below is a non-exhaustive list (as a reminder): * The title of the PR should describe the changes and starts with the associated issue number, like “#1234 Brief description”. * A release notes news fragment file was create in src/twisted/newsfragments/ (see: [Release notes fragments docs.](https://docs.twisted.org/en/latest/core/development/dev-process.html#release-notes-management)) * The automated tests were updated. -* Once all checks are green, request a review by leaving a comment that contains exactly the string `needs-review`. +* Once all checks are green, request a review by leaving a comment that contains exactly the string `please review`. Our bot will trigger the review process, by applying the pending review label and requesting a review from the Twisted dev team.