From 4cb71f9bc4b7c1e477fd61583314ccf12516541a Mon Sep 17 00:00:00 2001 From: Wim Lewis Date: Thu, 21 Mar 2019 21:48:55 -0700 Subject: [PATCH] Use 'is'/'is not' instead of '==' to avoid Py3 warnings about comparing disparate types. --- src/twisted/web/distrib.py | 2 +- src/twisted/web/newsfragments/9597.misc | 0 src/twisted/web/server.py | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 src/twisted/web/newsfragments/9597.misc diff --git a/src/twisted/web/distrib.py b/src/twisted/web/distrib.py index f85445e61b1..38f46a0ff9d 100644 --- a/src/twisted/web/distrib.py +++ b/src/twisted/web/distrib.py @@ -114,7 +114,7 @@ def __init__(self, request): self.request = request def finished(self, result): - if result != server.NOT_DONE_YET: + if result is not server.NOT_DONE_YET: assert isinstance(result, str), "return value not a string" self.request.write(result) self.request.finish() diff --git a/src/twisted/web/newsfragments/9597.misc b/src/twisted/web/newsfragments/9597.misc new file mode 100644 index 00000000000..e69de29bb2d diff --git a/src/twisted/web/server.py b/src/twisted/web/server.py index 23e3e408e6f..ada90476178 100644 --- a/src/twisted/web/server.py +++ b/src/twisted/web/server.py @@ -311,7 +311,7 @@ def render(self, resrc): body = epage.render(self) # end except UnsupportedMethod - if body == NOT_DONE_YET: + if body is NOT_DONE_YET: return if not isinstance(body, bytes): body = resource.ErrorPage(