Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support content-type overrides #289

Open
mattwwarren opened this issue Aug 27, 2020 · 1 comment
Open

Support content-type overrides #289

mattwwarren opened this issue Aug 27, 2020 · 1 comment

Comments

@mattwwarren
Copy link

This may be related to #132 so feel free to fold it into that but we ran into a scenario where we had to pass a meaningless files= kwarg to HTTPClient.request in order to get the proper Content-Type header. Would you be open to only setting that header if one does not exist in the headers= kwarg?

Happy to make that change, just wanted to confirm my design beforehand.

@twm
Copy link
Contributor

twm commented Sep 14, 2020

That sounds reasonable to me. I can see other use cases, e.g. using the json keyword argument with a JSON Patch content type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants