New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support coverage -p
#277
support coverage -p
#277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for this feature, but please do it at the source!
Thanks!
.travis.yml
Outdated
@@ -80,6 +80,7 @@ script: | |||
- tox | |||
|
|||
after_success: | |||
- coverage combine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update and run tox2travis.py instead of editing this file.
6129518
to
6a0454e
Compare
Feedback addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuing to work on this!
.travis.yml
Outdated
@@ -8,7 +8,7 @@ cache: pip | |||
jobs: | |||
include: | |||
- python: "3.8" | |||
env: TOXENV=towncrier,twine,check-manifest,flake8,docs | |||
env: TOXENV=twine,check-manifest,flake8,docs,coverage-report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preceding envs won't generate any coverage. Shouldn't tox2travis.py
filter out coverage-report
? This is causing the build to fail:
coverage-report run-test-pre: PYTHONHASHSEED='4152157654'
coverage-report run-test: commands[0] | coverage combine
No data to combine
ERROR: InvocationError for command /home/travis/build/twisted/treq/.tox/coverage-report/bin/coverage combine (exited with code 1)
tox.ini
Outdated
@@ -58,3 +57,9 @@ commands = | |||
changedir = docs | |||
commands = | |||
sphinx-build -b html . html | |||
|
|||
[testenv:coverage-report] | |||
depends = pypy,py27,py35,py36,py37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I didn't realize you can depend on factors alone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.