Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove module-level treq.content in favor of _Response.content #242

Open
glyph opened this issue May 23, 2019 · 0 comments
Open

remove module-level treq.content in favor of _Response.content #242

glyph opened this issue May 23, 2019 · 0 comments

Comments

@glyph
Copy link
Member

glyph commented May 23, 2019

We already have Response.content() which is what you should use.

The main purpose that treq.content serves is to trick unsuspecting passers-by into accidentally attempting to call it on an HTTPClient when they start replacing their global-treq-module usage with HTTPClient usage to make it more testable.

@glyph glyph changed the title remove treq.content remove module-level treq.content in favor of _Response.content Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant