Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on incremental in favor of general compatible solution #308

Open
altendky opened this issue Dec 20, 2020 · 0 comments · May be fixed by #491
Open

Remove dependency on incremental in favor of general compatible solution #308

altendky opened this issue Dec 20, 2020 · 0 comments · May be fixed by #491

Comments

@altendky
Copy link
Member

#297 (review)

For get_version I think that we should have this logic

See if version is a tuple and join them with a dot.
For anything else, just call str(version_object) and strip it.

In this way it will work with incremental and any other version objects.

towncrier shouldn't care about comparing versions...

It can try to be smart and detect that you are not adding a version older than the latest one in the file... but I think that is too much...and again it should be implemented with a naive compare

So I am +1 for remove the incremental dependency :) and use simple version strings for towncrier :)

I am using a fork of towncrier in which incremental is removed as at least 3 years ago, incremental was not playing nice with private PYPI repos due to a bug in setup tools

Sounds like we could remove the dependency specifically on incremental. Give it a shot if we get a chance.

@SmileyChris SmileyChris linked a pull request Mar 27, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant