Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue Addressable::IDNA exceptions #112

Open
1 of 3 tasks
dentarg opened this issue Mar 23, 2017 · 1 comment
Open
1 of 3 tasks

Rescue Addressable::IDNA exceptions #112

dentarg opened this issue Mar 23, 2017 · 1 comment

Comments

@dentarg
Copy link
Collaborator

dentarg commented Mar 23, 2017

From https://github.com/sporkmonger/addressable/blob/addressable-2.5.0/lib/addressable/idna/pure.rb#L378-L383

  • PunycodeBadInput
  • PunycodeBigOutput
  • PunycodeOverflow

I think all these cases was previously covered by twingly-url rescueing IDN::Idna::IdnaError, which was removed in 057f675 when we dropped use of libidn.

@dentarg
Copy link
Collaborator Author

dentarg commented Feb 7, 2019

The reason why the others isn't being rescued is that we want to write specs when adding them, thus we need input that triggers them (so we are able to prevent regressions in the future). :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant