Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump jwt version max version to 2.6 #626

Merged
merged 1 commit into from
Jan 5, 2023
Merged

chore: Bump jwt version max version to 2.6 #626

merged 1 commit into from
Jan 5, 2023
+1 −1

Conversation

MarcPer
Copy link
Contributor

@MarcPer MarcPer commented Jan 2, 2023

Fixes

Closes #625 by increasing the maximum allowed version of the ruby-jwt gem to be 2.6.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch

Sorry, something went wrong.

@MarcPer MarcPer changed the title Bump jwt version max version to 2.6.0 chore: Bump jwt version max version to 2.6.0 Jan 2, 2023
@MarcPer MarcPer changed the title chore: Bump jwt version max version to 2.6.0 chore: Bump jwt version max version to 2.6 Jan 3, 2023
@Hunga1 Hunga1 added type: twilio enhancement feature request on Twilio's roadmap status: waiting for feature feature will be implemented in the future labels Jan 5, 2023
@Hunga1
Copy link
Contributor

Hunga1 commented Jan 5, 2023

Thanks for the PR. The corresponding issue has been added to our internal backlog and has been prioritized for our upcoming sprint (DI-2507).

claudiachua
claudiachua approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@claudiachua claudiachua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudiachua claudiachua merged commit dc34785 into twilio:main Jan 5, 2023
@MarcPer MarcPer deleted the bump-jwt branch January 11, 2023 14:09
@sato11 sato11 mentioned this pull request Jan 18, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiachua claudiachua

Assignees
No one assigned
Labels
status: waiting for feature feature will be implemented in the future type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maximum allowed jwt version (2.5) is outdated
3 participants
@MarcPer @Hunga1 @claudiachua