FilterExpression's attributes are changed by the compiler

[ericmorand]

While using TwigPHP to parse a Twig template and apply some changes to the AST before it is sent to the compiler, we discovered that the compiler changes somes attributes of FilterExpression:

Twig/src/Node/Expression/FilterExpression.php

Line 30 in 51cfad8

$this->setAttribute('name', $name);

This is a violation of the purpose of a compiler: a compiler compiles an AST as-is without changing it. Would the AST needs to be changed, it must be done before it is sent to the compiler

This violation creates an obvious issue where changing the attributes of a FilterExpression node is reverted by the compiler - defeating the purpose of having an AST to begin with.

I'm not sure how spread this pattern is in TwigPHP code base. Hopefully not too much.