Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not clean up whitespace text nodes inside if tags #3738

Merged
merged 1 commit into from Dec 26, 2022

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Aug 24, 2022

No description provided.

@fabpot fabpot force-pushed the issue-3715 branch 3 times, most recently from 79d5c24 to 9310415 Compare December 26, 2022 17:03
@fabpot fabpot marked this pull request as ready for review December 26, 2022 17:03
@fabpot
Copy link
Contributor

fabpot commented Dec 26, 2022

I've updated this PR with another fix. Instead of making a special case in the Parser, I've updated the If node class to support empty nodes instead.

@fabpot
Copy link
Contributor

fabpot commented Dec 26, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit 7cbabe4 into twigphp:2.x Dec 26, 2022
@xabbuh xabbuh deleted the issue-3715 branch December 27, 2022 10:14
@xabbuh
Copy link
Contributor Author

xabbuh commented Dec 27, 2022

Thank you for the update Fabien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants