throwing syntax error when the matches regexp is not valid #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebMamba
changed the title
fabpot
force-pushed
the
twig-matches-fix-throwing-error
branch
from
88befbd
to
e3422e5
Compare
fabpot
force-pushed
the
twig-matches-fix-throwing-error
branch
from
e3422e5
to
a82e94d
Compare
|
Thank you @WebMamba. |
la5942
added a commit
to la5942/Twig
that referenced
this pull request
Feb 7, 2023
… subject to result in a non-match. Resolves BC break introduced in PR twigphp#3687 As per pattern in twigphp#3617
fabpot
added a commit
that referenced
this pull request
Feb 8, 2023
…942) This PR was merged into the 3.x branch. Discussion ---------- Restores the leniency of the `matches` twig comparison Restores the leniency of the `matches` twig comparison, allowing null subject to result in a non-match. Resolves BC break introduced in PR #3687 ref in #3801 (comment) As per pattern in #3617 Commits ------- f136668 Restores the leniency of the `matches` twig comparison, allowing null subject to result in a non-match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the symfony live, Fabien talk about a PR he did on the Expression Language component (https://github.com/symfony/symfony/pull/45875/files). The goal was to throw a more readable error when using the matchs operator. This think need to be fix in twig to. So as promises, here is my PR !
This is my first contrib to symfony so any advice is welcome ! 😁