Fix "include(template_from_string())" when not using a sandbox #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
regression-fix
branch
from
c920da3
to
0358afd
Compare
stof
reviewed
Oct 26, 2020
src/Extension/CoreExtension.php
Outdated
| $template->unwrap()->checkSecurity(); | ||
| // if a Template instance is passed, it might have been instantiated outside of a sandbox, check security | ||
| if ($template instanceof TemplateWrapper || $template instanceof Template) { | ||
| $template->unwrap()->checkSecurity(); |
There was a problem hiding this comment.
shouldn't this check also be done when the sandbox is already active, even if the $sandboxed argument is not explicitly set to true ?
There was a problem hiding this comment.
In that case, the check has already been done.
fabpot
force-pushed
the
regression-fix
branch
from
0358afd
to
9c29dfe
Compare
|
I've fixed another use case (when you pass an array of templates). /cc @stof |
fabpot
force-pushed
the
regression-fix
branch
from
9c29dfe
to
df9c9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #3411