Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Symfony 5 #3226

Merged
merged 1 commit into from Dec 27, 2019
Merged

Allow Symfony 5 #3226

merged 1 commit into from Dec 27, 2019

Conversation

Guite
Copy link
Contributor

@Guite Guite commented Dec 26, 2019

This fixes #3225

@nicolas-grekas
Copy link
Contributor

can you please check and confirm that the other extra extensions are ok?

@Guite Guite mentioned this pull request Dec 26, 2019
Merged
@Guite
Copy link
Contributor Author

Guite commented Dec 26, 2019

They are because I could install them. Otherwise composer would have complained I think.

@fabpot fabpot changed the base branch from 3.x to 2.x December 27, 2019 07:36
@fabpot
Copy link
Contributor

fabpot commented Dec 27, 2019

Thank you @Guite.

fabpot added a commit that referenced this pull request Dec 27, 2019
@fabpot
bug #3226 Allow Symfony 5 (Guite)
6acf02e 
This PR was submitted for the 3.x branch but it was merged into the 2.x branch instead (closes #3226).

Discussion
----------

Allow Symfony 5

This fixes #3225

Commits
-------

d735a43 support Sf5
@fabpot fabpot merged commit d735a43 into twigphp:2.x Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Guite @nicolas-grekas @fabpot