Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch filter documentation is missing preserve_keys argument #3159

Closed
ericmorand opened this issue Sep 24, 2019 · 2 comments
Closed

batch filter documentation is missing preserve_keys argument #3159

ericmorand opened this issue Sep 24, 2019 · 2 comments

Comments

@ericmorand
Copy link
Contributor

https://twig.symfony.com/doc/2.x/filters/batch.html

The third argument added by #2884 is missing from the doc.
@stof
Copy link
Member

stof commented Sep 24, 2019

I suggest you to open a PR fixing the doc (the doc is maintained in the doc folder of this repo)

@ericmorand
Copy link
Contributor Author

Will do. I'll finish my review of the doc and provide some PRs.

ericmorand added a commit to ericmorand/Twig that referenced this issue Oct 1, 2019
@ericmorand
Fix issue twigphp#3159
3ebda61
@fabpot fabpot closed this as completed Oct 1, 2019
fabpot pushed a commit to ericmorand/Twig that referenced this issue Oct 1, 2019
@ericmorand @fabpot
Fix issue twigphp#3159
cfac11e
fabpot added a commit that referenced this issue Oct 1, 2019
@fabpot
minor #3163 Fix issue #3159 (ericmorand)
8909a16 
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes #3163).

Discussion
----------

Fix issue #3159

Commits
-------

cfac11e Fix issue #3159
fabpot added a commit that referenced this issue Oct 1, 2019
@fabpot
Merge branch '1.x' into 2.x
f8c5f86 
* 1.x:
  Fix issue #3159
  Fix issue #3160
fabpot added a commit that referenced this issue Oct 1, 2019
@fabpot
Merge branch '2.x' into 3.x
b50062d 
* 2.x:
  Fix issue #3159
  Fix issue #3160
@mpdude mpdude mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @ericmorand @stof