Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into Pylint alternatives #56

Closed
Nour-Mws opened this issue Jan 11, 2023 · 2 comments
Closed

Look into Pylint alternatives #56

Nour-Mws opened this issue Jan 11, 2023 · 2 comments

Comments

@Nour-Mws
Copy link
Collaborator

From #39 (comment), which was part of a discussion on Pylint not supporting per-directory configuration:

[tool.pylint.tests]
disable = "missing-function-docstring,invalid-name,redefined-outer-name"

The .tests on the first line is disregarded (silently), and the disable directive is applied for all modules, not just our test code.

In fact, it seems that per-directory settings for Pylint is not supported upstream (and this issues was first reported in 2015)!..
[..]
[Consider] abandon[ing]/replac[ing] Pylint altogether. We're probably not there yet, but - frankly - it's popped into the back of my mind a couple of times now:
We're running into a fair amount of issues getting it properly configured.
Some of the warnings it produces are very opinionated/strict, even when I feel the code in question looks pretty good. Refactoring our code just to make Pylint happy, is something I'd rather not have to do a lot of...
Pylint seems to have fallen out of favor in recent times compared to other linters. For example, a lot of cookiecutter repos I've looked recently does not include it among their preferred linters. Also, this blog post compares a bunch of linters, and Pylint does not come out on top.

@mknorps
Copy link
Collaborator

mknorps commented Jan 24, 2023

#21 is also a pylint issue

@mknorps
Copy link
Collaborator

mknorps commented May 13, 2024

We moved to ruff. This was implemented by @jherland in a series of PRs: #424, #425, #426.

@mknorps mknorps closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants