From e42c560f2d086ca48bfa85e7f74dcdfdb12f89e7 Mon Sep 17 00:00:00 2001 From: Rohit Sharma Date: Fri, 15 May 2020 22:50:59 +0530 Subject: [PATCH 1/2] Explain the "dispose" method appropriately --- site/content/docs/5.0/components/alerts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/docs/5.0/components/alerts.md b/site/content/docs/5.0/components/alerts.md index a2fb75b917ee..628f36bfd12e 100644 --- a/site/content/docs/5.0/components/alerts.md +++ b/site/content/docs/5.0/components/alerts.md @@ -128,7 +128,7 @@ This makes an alert listen for click events on descendant elements which have th dispose - Destroys an element's alert. + Destroys an element's alert. (Removes stored data on the DOM element) From 1c26a8fe3547666a556e1434fbf9a3a5ddd6b5db Mon Sep 17 00:00:00 2001 From: Rohit Sharma Date: Mon, 6 Jul 2020 00:02:57 +0530 Subject: [PATCH 2/2] Explain dispose method for the remaining components --- site/content/docs/5.0/components/buttons.md | 2 +- site/content/docs/5.0/components/carousel.md | 2 +- site/content/docs/5.0/components/collapse.md | 2 +- site/content/docs/5.0/components/dropdowns.md | 2 +- site/content/docs/5.0/components/modal.md | 2 +- site/content/docs/5.0/components/popovers.md | 2 +- site/content/docs/5.0/components/scrollspy.md | 2 +- site/content/docs/5.0/components/tooltips.md | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/site/content/docs/5.0/components/buttons.md b/site/content/docs/5.0/components/buttons.md index eaede8f4eb99..4b4522ab77f0 100644 --- a/site/content/docs/5.0/components/buttons.md +++ b/site/content/docs/5.0/components/buttons.md @@ -155,7 +155,7 @@ var bsButton = new bootstrap.Button(button) dispose - Destroys an element's button. + Destroys an element's button. (Removes stored data on the DOM element) diff --git a/site/content/docs/5.0/components/carousel.md b/site/content/docs/5.0/components/carousel.md index b0de24cce358..13610a4cfe90 100644 --- a/site/content/docs/5.0/components/carousel.md +++ b/site/content/docs/5.0/components/carousel.md @@ -324,7 +324,7 @@ var carousel = new bootstrap.Carousel(myCarousel, { dispose - Destroys an element's carousel. + Destroys an element's carousel. (Removes stored data on the DOM element) getInstance diff --git a/site/content/docs/5.0/components/collapse.md b/site/content/docs/5.0/components/collapse.md index a182ab2301df..a93d2e14c896 100644 --- a/site/content/docs/5.0/components/collapse.md +++ b/site/content/docs/5.0/components/collapse.md @@ -224,7 +224,7 @@ var bsCollapse = new bootstrap.Collapse(myCollapse, { dispose - Destroys an element's collapse. + Destroys an element's collapse. (Removes stored data on the DOM element) getInstance diff --git a/site/content/docs/5.0/components/dropdowns.md b/site/content/docs/5.0/components/dropdowns.md index deb86c1fbf40..addfb39927e0 100644 --- a/site/content/docs/5.0/components/dropdowns.md +++ b/site/content/docs/5.0/components/dropdowns.md @@ -903,7 +903,7 @@ Note when `boundary` is set to any value other than `'scrollParent'`, the style dispose - Destroys an element's dropdown. + Destroys an element's dropdown. (Removes stored data on the DOM element) diff --git a/site/content/docs/5.0/components/modal.md b/site/content/docs/5.0/components/modal.md index 19d0aae3765f..e4b25b4445ef 100644 --- a/site/content/docs/5.0/components/modal.md +++ b/site/content/docs/5.0/components/modal.md @@ -946,7 +946,7 @@ Manually readjust the modal's position if the height of a modal changes while it #### dispose -Destroys an element's modal. +Destroys an element's modal. (Removes stored data on the DOM element) {{< highlight js >}}myModal.dispose(){{< /highlight >}} diff --git a/site/content/docs/5.0/components/popovers.md b/site/content/docs/5.0/components/popovers.md index 4af07a2232d3..ed7dfb1b2d83 100644 --- a/site/content/docs/5.0/components/popovers.md +++ b/site/content/docs/5.0/components/popovers.md @@ -323,7 +323,7 @@ Toggles an element's popover. **Returns to the caller before the popover has act #### dispose -Hides and destroys an element's popover. Popovers that use delegation (which are created using [the `selector` option](#options)) cannot be individually destroyed on descendant trigger elements. +Hides and destroys an element's popover (Removes stored data on the DOM element). Popovers that use delegation (which are created using [the `selector` option](#options)) cannot be individually destroyed on descendant trigger elements. {{< highlight js >}}myPopover.dispose(){{< /highlight >}} diff --git a/site/content/docs/5.0/components/scrollspy.md b/site/content/docs/5.0/components/scrollspy.md index 94ea1f9e1f3e..06504a6f5b73 100644 --- a/site/content/docs/5.0/components/scrollspy.md +++ b/site/content/docs/5.0/components/scrollspy.md @@ -285,7 +285,7 @@ dataSpyList.forEach(function (dataSpyEl) { #### dispose -Destroys an element's scrollspy. +Destroys an element's scrollspy. (Removes stored data on the DOM element) #### getInstance diff --git a/site/content/docs/5.0/components/tooltips.md b/site/content/docs/5.0/components/tooltips.md index 947a50f88d2c..cf9a678ff943 100644 --- a/site/content/docs/5.0/components/tooltips.md +++ b/site/content/docs/5.0/components/tooltips.md @@ -330,7 +330,7 @@ Toggles an element's tooltip. **Returns to the caller before the tooltip has act #### dispose -Hides and destroys an element's tooltip. Tooltips that use delegation (which are created using [the `selector` option](#options)) cannot be individually destroyed on descendant trigger elements. +Hides and destroys an element's tooltip (Removes stored data on the DOM element). Tooltips that use delegation (which are created using [the `selector` option](#options)) cannot be individually destroyed on descendant trigger elements. {{< highlight js >}}tooltip.dispose(){{< /highlight >}}