Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals using H1 #37244

Closed
3 tasks done
leecollings-sb opened this issue Oct 3, 2022 · 2 comments
Closed
3 tasks done

Modals using H1 #37244

leecollings-sb opened this issue Oct 3, 2022 · 2 comments

Comments

@leecollings-sb
Copy link

leecollings-sb commented Oct 3, 2022

Prerequisites

Describe the issue

The latest version state this:

Use <h1> for all .modal-title instances in our docs

You shouldn't be doing this, this will lead to MULTIPLE H1s on the page markup, which is terrible for SEO and will instantly reduce your pagescore.

This shouldn't be in your docs, because this will lead many people down a path that will ruin their page rankings. This should be reverted back to a H3 or something H2 or lower.

Reduced test cases

n/a

What operating system(s) are you seeing the problem on?

Windows, macOS, Android, iOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari, Firefox, Microsoft Edge, Opera

What version of Bootstrap are you using?

v5.2.2

@GeoSot
Copy link
Member

GeoSot commented Oct 3, 2022

Please try to be helpful next time, including the proper referrals in issue, avoiding spamming duplications
It is as annoying as confusing to find the same comments in 3 places and on top without linking them.

Closing it as it is answered below
#37210 (comment)
#37179 (comment)

and continued on #37210

@GeoSot GeoSot closed this as completed Oct 3, 2022
@leecollings-sb
Copy link
Author

None of my issues are completed though, so this can't be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants