Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Webpack and Vite PNGs by SVGs #37199

Merged
merged 4 commits into from Sep 26, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 23, 2022

Related PR

Linked to #36899

Description

Replace Webpack and Vite PNGs by SVGs.

Note: I haven't found a SVG version for Parcel.

Motivation & Context

The images weights is smaller:

Webpack Vite
PNG: 1.9K PNG: 4.0K
SVG: 565B SVG: 1.5K

Live preview

Screenshot 2022-09-24 at 00 07 58

@julien-deramond julien-deramond changed the title Replace Webpack and Vite pngs by svgs Replace Webpack and Vite PNGs by SVGs Sep 23, 2022
@julien-deramond julien-deramond force-pushed the main-jd-replace-vite-webpack-pngs-by-svgs branch from 054cfb2 to 6244127 Compare September 24, 2022 06:56
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @XhmikosR probably has some image optimizations to apply ;).

@XhmikosR
Copy link
Member

Thanks, I'll try to have a look at this in the next days!

@XhmikosR XhmikosR merged commit eff658e into main Sep 26, 2022
@XhmikosR XhmikosR deleted the main-jd-replace-vite-webpack-pngs-by-svgs branch September 26, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants