Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: fix case with invalid markup #37190

Merged
merged 3 commits into from Sep 27, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Sep 22, 2022

Backward compatibility. (Should be removed in v6)

closes #37111

@GeoSot GeoSot requested a review from a team as a code owner September 22, 2022 00:04
@GeoSot GeoSot force-pushed the gs/support-dropdown-backward-compatibility branch from 7a21478 to eb609fe Compare September 23, 2022 08:13
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before merging @XhmikosR would you be able to check if your issue is well-fixed in your project? I'm still unsure if what I reproduced with my manual tests was exactly your use case :)

@XhmikosR
Copy link
Member

Thanks, I'll try to have a look at this in the next days!

@XhmikosR
Copy link
Member

Fix confirmed, thanks!

@XhmikosR XhmikosR changed the title Dropdown should be able to work with invalid markup Dropdown: fix cases with invalid markup Sep 27, 2022
@XhmikosR XhmikosR changed the title Dropdown: fix cases with invalid markup Dropdown: fix case with invalid markup Sep 27, 2022
@XhmikosR XhmikosR merged commit 597c402 into main Sep 27, 2022
@XhmikosR XhmikosR deleted the gs/support-dropdown-backward-compatibility branch September 27, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

v5.2.1 dropdown TypeError
3 participants