Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly target .btn-check and undo :hover #37165

Merged
merged 2 commits into from Sep 20, 2022

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Sep 17, 2022

rather than the other way around, which caused specificity issues. Follow-up patch to #37026

closes #37130 (presumably?), closes #37115

@patrickhlauke
Copy link
Member Author

checking https://deploy-preview-37165--twbs-bootstrap.netlify.app/docs/5.2/forms/checks-radios/#checkbox-toggle-buttons this still does what the original intended ... suppress the confusing/horrid hover on checkbox/radio buttons (which was particularly confusing for outline buttons), but avoids causing problems like in https://codepen.io/rgameshow/pen/zYjqoRK

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

rather than the other way around, which caused specificity issues
@mdo mdo force-pushed the patrickhlauke-button-styles-patch branch from 38bf848 to 2781106 Compare September 20, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

.btn-link:hover styles are overridden Buttons bug
2 participants