Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set toast z-index variable in the correct spot #37118

Merged
merged 1 commit into from Sep 20, 2022
Merged

Set toast z-index variable in the correct spot #37118

merged 1 commit into from Sep 20, 2022

Conversation

flavio-b
Copy link
Contributor

@flavio-b flavio-b commented Sep 9, 2022

The.toast-container tries to use the z-index CSS variable, which is defined under .toast.

However, this variable is not accessible to the .toast-container, because it is the parent of .toast. This PR copies the variable to the spot where it can be used.

Fixes #37136
Fixes #37175

I'm not sure how to handle the documentation in this case.

The .toast-container tries to use the z-index CSS variable, which is defined under .toast. 
However, this variable is not accessible to the container. This change copies the variable to the spot where it can be used.
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdo mdo merged commit 636bb49 into twbs:main Sep 20, 2022
@flavio-b flavio-b deleted the toast-z-index branch September 20, 2022 12:36
@Splines Splines mentioned this pull request Aug 27, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation Toast Toast z-index css variable not used
3 participants