Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip manual toggling #37086

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Fix tooltip manual toggling #37086

merged 2 commits into from
Sep 7, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Sep 5, 2022

Partial regression of SHA: 9b9372e

closes #37071

@GeoSot GeoSot marked this pull request as ready for review September 5, 2022 23:48
@GeoSot GeoSot requested a review from a team as a code owner September 5, 2022 23:48
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK all the details regarding popovers and tooltips but this change sounds good to me.
The bug is fixed and my non-regression testing didn't show anything wrong.

Note: Maybe need a rebase or an empty push to trigger the jobs and be sure that everything's green

@GeoSot GeoSot merged commit 9494569 into main Sep 7, 2022
@GeoSot GeoSot deleted the gs/regression-on-tooltip branch September 7, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

v5.2.0 - Popover with trigger: "manual" shows and immediately hides when calling toggle()
2 participants