Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert db61cf3 for $text-muted default value #36680

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 5, 2022

Fixes #36096

Proposing to revert db61cf3; probably the safest move here for the v5.2.0.

(Haven't yet looked at the Dark Mode PR but depending on how themes are handled and if dynamic/contextual dark theme are possible, that could help with this definition of .text-muted)

If this PR is merged we could reopen #34457 and try to tackle it for v5.3.0.

Live preview

/cc @mdo

@julien-deramond julien-deramond marked this pull request as ready for review July 5, 2022 19:19
@julien-deramond julien-deramond requested a review from a team as a code owner July 5, 2022 19:19
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! We can create dark mode specific styles for this in v5.3.0.

@julien-deramond julien-deramond merged commit 7d0b224 into main Jul 6, 2022
@julien-deramond julien-deramond deleted the main-revert-text-muted-modification branch July 6, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text-muted not visible on bg-dark
2 participants