Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New align-self: center default for btn class causes regression in vertical button stacks inside flex containers #35126

Closed
andreas-venturini opened this issue Oct 6, 2021 · 3 comments · Fixed by #35143

Comments

@andreas-venturini
Copy link

andreas-venturini commented Oct 6, 2021

Consider the following snippet (slightly modified example from #34834 (comment))

<div class="d-flex flex-column">
  <button type="button" class="m-2 btn btn-primary">Default</button>
  <button type="button" class="m-2 btn btn-primary btn-sm">Small</button>
  <button type="button" class="m-2 btn btn-primary btn-md">Medium</button>
  <button type="button" class="m-2 btn btn-primary btn-lg">Large</button>
</div>

Bootstrap 5.1.1 produces the following output:

image

With Bootstrap 5.1.2 and align-self: center this results in the following:

bs_5 1 2

@andreas-venturini andreas-venturini changed the title New align-self: center default for btn class breaks vertical button stacks inside flex container New align-self: center default for btn class causes regression in vertical button stacks inside flex containers Oct 6, 2021
@mdo mdo added this to To do in v5.2.0 via automation Oct 6, 2021
@amshkv
Copy link

amshkv commented Oct 8, 2021

faced the same situation

@XhmikosR
Copy link
Member

XhmikosR commented Oct 9, 2021

We reverted the offending patch in #35143 and we'll release 5.1.3 later today.

@XhmikosR XhmikosR closed this as completed Oct 9, 2021
@XhmikosR
Copy link
Member

XhmikosR commented Oct 9, 2021

v5.1.3 is out 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants