Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollup: specify generatedCode: 'es2015' #35070

Merged
merged 1 commit into from Oct 4, 2021
Merged

rollup: specify generatedCode: 'es2015' #35070

merged 1 commit into from Oct 4, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 28, 2021 •
edited

This will make use of const and modern features (which we are already using in our code) in the generated rollup code.

TODO:

  • Revert the dist commits before merging

@XhmikosR XhmikosR force-pushed the main-xmr-rollup branch 2 times, most recently from 8ddc7ca to 2f06e66 Compare September 28, 2021 16:24
@XhmikosR XhmikosR added this to In progress in v5.1.2 via automation Oct 4, 2021
@XhmikosR XhmikosR marked this pull request as ready for review October 4, 2021 16:42
@XhmikosR XhmikosR requested a review from a team as a code owner October 4, 2021 16:42
v5.1.2 automation moved this from In progress to Ready to merge Oct 4, 2021
@XhmikosR XhmikosR merged commit c81c645 into main Oct 4, 2021
v5.1.2 automation moved this from Ready to merge to Done Oct 4, 2021
@XhmikosR XhmikosR deleted the main-xmr-rollup branch October 4, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoSot GeoSot GeoSot approved these changes

Assignees
No one assigned
Labels
build v5
Projects
No open projects
v5.1.2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @GeoSot