Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sass variable instead of RGB components #35017

Merged
merged 2 commits into from Sep 28, 2021
Merged

Use Sass variable instead of RGB components #35017

merged 2 commits into from Sep 28, 2021

Conversation

tagliala
Copy link
Contributor

All other rgba() calls use a Sass variable, except for the ones fixed
in this commit

@tagliala tagliala requested a review from a team as a code owner September 19, 2021 13:09
@tagliala tagliala marked this pull request as draft September 19, 2021 13:11
@tagliala tagliala force-pushed the chore/use-variable-name-for-rgba branch from a4aba53 to 9f0ffd3 Compare September 19, 2021 13:12
@tagliala
Copy link
Contributor Author

tagliala commented Sep 19, 2021 •
edited

Failures depend by Coveralls, which is down for maintenance

@tagliala tagliala changed the title Use Sass variable instead of rgba values Use Sass variable instead of RGB components Sep 19, 2021
@tagliala tagliala marked this pull request as ready for review September 19, 2021 18:29
@tagliala
Use Sass variable instead of RGB components
dd75f27 
All other `rgba()` calls use a Sass variable, except for the ones fixed
in this commit
@tagliala tagliala force-pushed the chore/use-variable-name-for-rgba branch from 9f0ffd3 to dd75f27 Compare September 23, 2021 10:59
ffoodd
ffoodd approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no argument to oppose so let's do this 👌

@XhmikosR XhmikosR added this to In progress in v5.1.2 via automation Sep 28, 2021
@XhmikosR XhmikosR merged commit 4fffcf7 into twbs:main Sep 28, 2021
v5.1.2 automation moved this from In progress to Done Sep 28, 2021
@tagliala tagliala deleted the chore/use-variable-name-for-rgba branch September 28, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.1.2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tagliala @ffoodd @XhmikosR