Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border-radius sizes to small and large .form-selects #34853

Merged
merged 5 commits into from Sep 7, 2021

Conversation

crdo
Copy link
Contributor

@crdo crdo commented Aug 31, 2021

Adds border-radius modifiers for small and large Select to _form-select.scss
Adds corresponding variables to _variables.scss

Fixes #34852

@crdo crdo requested a review from a team as a code owner August 31, 2021 12:32
scss/forms/_form-select.scss Outdated Show resolved Hide resolved
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the 0 fallback, but apart from that it's really good, thanks!

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdo mdo added this to In progress in v5.1.1 via automation Sep 1, 2021
@mdo mdo removed this from In progress in v5.1.1 Sep 1, 2021
@mdo mdo added this to In progress in v5.2.0 via automation Sep 7, 2021
@XhmikosR XhmikosR moved this from In progress to Review in progress in v5.2.0 Sep 7, 2021
@XhmikosR XhmikosR changed the title Fixes #34852 Select does not have border radius modificators for large and small variant Fix select not having border radius modificators for large and small variants Sep 7, 2021
@mdo mdo added this to In progress in v5.1.2 via automation Sep 7, 2021
@mdo mdo changed the title Fix select not having border radius modificators for large and small variants Add border-radius sizes to small and large .form-selects Sep 7, 2021
v5.2.0 automation moved this from Review in progress to Reviewer approved Sep 7, 2021
v5.1.2 automation moved this from In progress to Ready to merge Sep 7, 2021
@mdo mdo merged commit dbe0ad4 into twbs:main Sep 7, 2021
v5.2.0 automation moved this from Reviewer approved to Done Sep 7, 2021
v5.1.2 automation moved this from Ready to merge to Done Sep 7, 2021
@mdo mdo removed this from Done in v5.2.0 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.1.2
  
Done
Development

Successfully merging this pull request may close these issues.

Select does not have border radius modificators for large and small variant
4 participants