Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font size variable name #34679

Merged
merged 4 commits into from Aug 5, 2021
Merged

Fix font size variable name #34679

merged 4 commits into from Aug 5, 2021

Conversation

semihraifgurel
Copy link
Contributor

No description provided.

@semihraifgurel semihraifgurel requested a review from a team as a code owner August 4, 2021 17:05
@ffoodd
Copy link
Member

ffoodd commented Aug 4, 2021

$variable-prefix is bs- so this fix is invalid. Moreover you'd need to change it accordingly through the whole codebase and not a single occurrence.

My bad I read the diff the wrong way 🤦

@ffoodd ffoodd closed this Aug 4, 2021
@ffoodd ffoodd reopened this Aug 4, 2021
@mdo mdo added this to In progress in v5.1.1 via automation Aug 4, 2021
@XhmikosR XhmikosR moved this from In progress to Reviewer approved in v5.1.1 Aug 5, 2021
@XhmikosR XhmikosR changed the title Font size variable name fixed Fix font size variable name Aug 5, 2021
@XhmikosR XhmikosR merged commit f4fd271 into twbs:main Aug 5, 2021
v5.1.1 automation moved this from Reviewer approved to Done Aug 5, 2021
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
GHSVS-de added a commit to GHSVS-de/tpl_bs4ghsvs that referenced this pull request Aug 27, 2021
@Dok11
Copy link

Dok11 commented Sep 2, 2021

0ced8a6#diff-1a18889ae3c2fbdc988fd3df1faea3e8a6ebcf581025c8be8ea4843db53e6253R30
really useful change. When it will be presented on the website in archive?

Here still version with bug from 4 Aug 2021.
https://getbootstrap.com/docs/5.1/getting-started/download/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.1.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants