Add Fathom Analytics to v5 docs #33904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
May 11, 2021
| @@ -5,3 +5,4 @@ | |||
| ga('send', 'pageview'); | |||
| </script> | |||
| <script async src="https://www.google-analytics.com/analytics.js"></script> | |||
| <script defer src="https://cdn.usefathom.com/script.js" data-site="TAXRUMOF"></script> | |||
There was a problem hiding this comment.
Any specific reason this is defer and not async?
There was a problem hiding this comment.
It's what they included in their code snippet. We can try to switch it around.
There was a problem hiding this comment.
@mdo we should drop GA, shouldn't we?
|
Shipping as-is for now—will revisit for v5.1.0. |
XhmikosR
pushed a commit
that referenced
this pull request
May 14, 2021
* Add Fathom Analytics to v5 docs * newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.