Don't redefine $list-group-color in loop

[mhw]

The loop in scss/_list_group.scss uses $list-group-color as though it was a local variable, but is in fact overwriting the setting from _variables.scss. This means that using the value of $list-group-color in other stylesheets included in the scss build will get the wrong color value (I'd expect it to be #212529, but it is in fact #141619).

[ffoodd]

Thanks! Confirmed in a Sassmeister.

If we're into this, $list-group-background doesn't match a global variable (the global one is $list-group-bg) so its override is not needed. But we could also harmonize naming in the loop to use $list-group-variant-bg. Does that sound accurate?

[mhw]

Yep, that's right: I renamed $list-group-background in the loop for consistency between the two "local" variables, not that it clashes with anything else. I'll update to $list-group-variant-bg as I can see that's more inline with the conventions.

[ffoodd]

Thanks for tackling this!

[ffoodd]

As a sidenote we should check if we're not doping the same error somewhere else.

[mhw]

Yes, that's a good idea. I did a quick visual check with egrep '^ +\$' scss/* and didn't spot any other obvious occurrences, but I don't know the code base well enough to consider that exhaustive.

[ffoodd]

Thanks for trying though :)