Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary classes #33850

Merged
merged 3 commits into from
May 6, 2021
Merged

Fix unnecessary classes #33850

merged 3 commits into from
May 6, 2021

Conversation

jrn2778
Copy link
Contributor

@jrn2778 jrn2778 commented May 6, 2021

Fixes #33847

I made all the changes suggested for the "Border hero with cropped image and shadows".

I did not make the change for the centered hero because I could not verify that it would produce the exact same result as prior to the change. Was hoping someone else could double check that again and I could make adjustments as needed.

@mdo
Copy link
Member

mdo commented May 6, 2021

I did not make the change for the centered hero because I could not verify that it would produce the exact same result as prior to the change. Was hoping someone else could double check that again and I could make adjustments as needed.

Confirmed it—go ahead and make the change in this PR if you don't mind :).

@mdo mdo added the examples label May 6, 2021
@mdo mdo added this to Inbox in v5.0.1 via automation May 6, 2021
jrn2778 and others added 2 commits May 6, 2021 13:41
@jrn2778
Copy link
Contributor Author

jrn2778 commented May 6, 2021

@mdo Thank you for the input! I made both changes :)

@mdo mdo merged commit eb73a2f into twbs:main May 6, 2021
v5.0.1 automation moved this from Inbox to Done May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.1
  
Done
Development

Successfully merging this pull request may close these issues.

Possible mistakes at https://getbootstrap.com/docs/5.0/examples/heroes/
2 participants