Refactor: move disposing properties into the base class #33740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Apr 25, 2021
js/src/base-component.js
Outdated
| @@ -31,7 +31,10 @@ class BaseComponent { | |||
| dispose() { | |||
| Data.remove(this._element, this.constructor.DATA_KEY) | |||
| EventHandler.off(this._element, `.${this.constructor.DATA_KEY}`) | |||
| this._element = null | |||
|
|
|||
| for (const propertyName of Object.getOwnPropertyNames(this)) { | |||
There was a problem hiding this comment.
I'd rather not use for...of yet.
XhmikosR
changed the title
super.dispose() can be responsible for its children properties disposalsuper.dispose() can be responsible for its children properties disposal
GeoSot
force-pushed
the
gs-dispose-can-handle-all-obj-properties
branch
from
a5c1a22
to
58a7eca
Compare
alpadev
approved these changes
Apr 26, 2021
…operties disposal
GeoSot
force-pushed
the
gs-dispose-can-handle-all-obj-properties
branch
from
58a7eca
to
66e54ab
Compare
XhmikosR
changed the title
super.dispose() can be responsible for its children properties disposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr :
Moves some more functionality to
base-component, transferring some responsibility of disposal, to parent classEach component, dusting disposal, sets its protected properties to
null. So the same can be done in one place for all children components