Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract static DATA_KEY & EVENT_KEY to base-component #33635

Merged
merged 1 commit into from May 11, 2021
Merged

Extract static DATA_KEY & EVENT_KEY to base-component #33635

merged 1 commit into from May 11, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Apr 15, 2021 •
edited by XhmikosR

  • Force each plugin that extends base-components to implement a static method NAME()
  • Remove redundant NAME argument from 'Utils.defineJQueryPlugin' & fix test

alecpl
alecpl reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@alecpl alecpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love your refactorings @GeoSot

js/src/util/index.js Outdated Show resolved Hide resolved
js/src/base-component.js Show resolved Hide resolved
@GeoSot GeoSot marked this pull request as ready for review April 15, 2021 07:17
@GeoSot GeoSot requested a review from a team as a code owner April 15, 2021 07:17
@GeoSot GeoSot force-pushed the gs-extract-data_key-to-base_component branch 3 times, most recently from 272dced to a7d6ec6 Compare April 19, 2021 21:59
@GeoSot GeoSot added this to Inbox in v5.0.1 via automation Apr 22, 2021
@GeoSot GeoSot force-pushed the gs-extract-data_key-to-base_component branch from a7d6ec6 to 812799b Compare April 25, 2021 23:21
@GeoSot GeoSot changed the title Js: Extract static DATA_KEY to base-component Js: Extract static DATA_KEY & EVENT_KEY to base-component Apr 26, 2021
@GeoSot GeoSot force-pushed the gs-extract-data_key-to-base_component branch 2 times, most recently from c195b34 to 6c73291 Compare April 26, 2021 00:03
@GeoSot GeoSot added the tests label Apr 26, 2021
v5.0.1 automation moved this from Inbox to Approved Apr 26, 2021
@GeoSot GeoSot force-pushed the gs-extract-data_key-to-base_component branch 3 times, most recently from 8ef97c1 to c8cc214 Compare May 10, 2021 22:07
@GeoSot
Js: Extract static DATA_KEY & EVENT_KEY to base-component
12e7aa0 
* Force each plugin that extends base-components to implement static method 'NAME()'
* Remove redundant 'NAME' argument from 'Utils..defineJQueryPlugin' & fix test
@GeoSot GeoSot force-pushed the gs-extract-data_key-to-base_component branch from c8cc214 to 12e7aa0 Compare May 11, 2021 07:39
@XhmikosR XhmikosR changed the title Js: Extract static DATA_KEY & EVENT_KEY to base-component Extract static DATA_KEY & EVENT_KEY to base-component May 11, 2021
@XhmikosR XhmikosR merged commit 9fe36ed into main May 11, 2021
v5.0.1 automation moved this from Approved to Done May 11, 2021
@XhmikosR XhmikosR deleted the gs-extract-data_key-to-base_component branch May 11, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecpl alecpl alecpl left review comments

@alpadev alpadev alpadev approved these changes

@rohit2sharma95 rohit2sharma95 Awaiting requested review from rohit2sharma95

Assignees
No one assigned
Labels
js refactoring tests v5
Projects
No open projects
v5.0.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeoSot @alecpl @alpadev @XhmikosR