Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge js-components transitionend listener callbacks into one method #33609

Merged
merged 1 commit into from May 10, 2021
Merged

Merge js-components transitionend listener callbacks into one method #33609

merged 1 commit into from May 10, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Apr 10, 2021

No description provided.

@GeoSot GeoSot force-pushed the gs-use-a-standard-method-to-execute-callbacks-inside-components branch 2 times, most recently from c819c53 to 2d8bda7 Compare April 11, 2021 18:55
@GeoSot GeoSot marked this pull request as ready for review April 11, 2021 19:15
@GeoSot GeoSot requested a review from a team as a code owner April 11, 2021 19:15
alpadev
alpadev reviewed Apr 12, 2021
View reviewed changes
js/src/alert.js Outdated Show resolved Hide resolved
alpadev
alpadev reviewed Apr 12, 2021
View reviewed changes
js/src/base-component.js Outdated Show resolved Hide resolved
@GeoSot GeoSot force-pushed the gs-use-a-standard-method-to-execute-callbacks-inside-components branch 4 times, most recently from a12d32f to 518f7b1 Compare April 19, 2021 08:32
@GeoSot GeoSot added this to Inbox in v5.0.1 via automation Apr 22, 2021
@GeoSot GeoSot mentioned this pull request Apr 24, 2021
Open
@GeoSot GeoSot requested a review from alpadev April 26, 2021 11:49
alpadev
alpadev approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@alpadev alpadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

v5.0.1 automation moved this from Inbox to Approved Apr 26, 2021
@GeoSot GeoSot force-pushed the gs-use-a-standard-method-to-execute-callbacks-inside-components branch from 518f7b1 to 02fe971 Compare May 5, 2021 21:07
@GeoSot GeoSot requested a review from rohit2sharma95 May 6, 2021 09:14
@alpadev alpadev mentioned this pull request May 6, 2021
Merged
rohit2sharma95
rohit2sharma95 approved these changes May 8, 2021
View reviewed changes
Copy link
Collaborator

@rohit2sharma95 rohit2sharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GeoSot ❤️

@rohit2sharma95
Copy link
Collaborator

Bundlewatch limits can be tightened a little bit? @XhmikosR

@GeoSot GeoSot force-pushed the gs-use-a-standard-method-to-execute-callbacks-inside-components branch from 82004ff to fa0311a Compare May 10, 2021 20:13
@GeoSot GeoSot force-pushed the gs-use-a-standard-method-to-execute-callbacks-inside-components branch from fa0311a to 299b7aa Compare May 10, 2021 20:51
@mdo mdo merged commit 90b1a69 into main May 10, 2021
@mdo mdo deleted the gs-use-a-standard-method-to-execute-callbacks-inside-components branch May 10, 2021 20:59
v5.0.1 automation moved this from Approved to Done May 10, 2021
@XhmikosR XhmikosR changed the title Merge js-components 'transitionend' listener callbacks into one method Merge js-components transitionend listener callbacks into one method May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpadev alpadev alpadev approved these changes

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

Assignees
No one assigned
Labels
js refactoring v5
Projects
No open projects
v5.0.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeoSot @rohit2sharma95 @alpadev @mdo