Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover/Tooltip: streamline config property to start with underscore #33381

Merged
merged 2 commits into from May 12, 2021
Merged

Popover/Tooltip: streamline config property to start with underscore #33381

merged 2 commits into from May 12, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Mar 16, 2021

No description provided.

@GeoSot GeoSot requested a review from a team as a code owner March 16, 2021 17:17
@rohit2sharma95
Copy link
Collaborator

rohit2sharma95 commented Mar 16, 2021 •
edited

Although this is not really a protected property, its name was not started with an underscore (_) because it is a protected property used by a child class.

Nevertheless, it is just a property (But you should keep the consistent naming convention IMO 🙂)

@XhmikosR
Copy link
Member

XhmikosR commented Mar 17, 2021 •
edited

I assume these were the only places? The reason must be because these two components share common parts.

@GeoSot
Copy link
Member Author

GeoSot commented Mar 17, 2021

I have searched the whole project. I didn't found it anywhere else

@GeoSot GeoSot force-pushed the gs-streamline-tooltp-popover-config-property branch from ceaaf21 to 708b81a Compare March 17, 2021 16:20
@GeoSot GeoSot added this to Inbox in v5.0.1 via automation Apr 22, 2021
@GeoSot GeoSot removed this from Inbox in v5.0.1 May 10, 2021
@GeoSot GeoSot added this to In progress in v5.1.0 via automation May 10, 2021
@GeoSot GeoSot removed this from In progress in v5.1.0 May 11, 2021
@GeoSot GeoSot added this to Inbox in v5.0.2 via automation May 11, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.2 May 11, 2021
@XhmikosR XhmikosR changed the title Streamline 'config' property name on Tooltip/Popover Streamline config property name in Tooltip/Popover May 11, 2021
@XhmikosR XhmikosR removed this from Review in v5.0.2 May 11, 2021
@XhmikosR XhmikosR added this to Inbox in v5.0.1 via automation May 11, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.1 May 11, 2021
@GeoSot GeoSot force-pushed the gs-streamline-tooltp-popover-config-property branch from 708b81a to de85532 Compare May 11, 2021 08:18
@GeoSot GeoSot force-pushed the gs-streamline-tooltp-popover-config-property branch from a197114 to a180b5c Compare May 11, 2021 09:22
v5.0.1 automation moved this from Review to Approved May 12, 2021
@XhmikosR XhmikosR changed the title Streamline config property name in Tooltip/Popover Popover/Tooltip: streamline config property to start with underscore May 12, 2021
@XhmikosR XhmikosR merged commit 9a9e224 into main May 12, 2021
v5.0.1 automation moved this from Approved to Done May 12, 2021
@XhmikosR XhmikosR deleted the gs-streamline-tooltp-popover-config-property branch May 12, 2021 09:16
@twbs twbs deleted a comment from tungphan995 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

@alpadev alpadev Awaiting requested review from alpadev

Assignees
No one assigned
Labels
js refactoring v5
Projects
No open projects
v5.0.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeoSot @rohit2sharma95 @XhmikosR