Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sibling card links in RTL #33154

Merged
merged 2 commits into from Feb 22, 2021
Merged

Fix sibling card links in RTL #33154

merged 2 commits into from Feb 22, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Feb 19, 2021 •
edited

@ffoodd ffoodd requested a review from a team as a code owner February 19, 2021 12:44
@ffoodd ffoodd changed the title fix(card): siblings card links in RTL Siblings card links in RTL Feb 19, 2021
@ffoodd ffoodd mentioned this pull request Feb 19, 2021
Open
20 tasks
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta3 via automation Feb 19, 2021
@XhmikosR XhmikosR changed the title Siblings card links in RTL Fix sibling card links in RTL Feb 19, 2021
@aqeelat
Copy link
Contributor

aqeelat commented Feb 19, 2021 •
edited

A better solution is to add /* rtl:options:{} */ in a line before 72. This way, it replaces the word "left" with "right" in the css.
#33155

margin-inline-start would also work, but I think @XhmikosR does not recommend it.

@ffoodd
Copy link
Member Author

ffoodd commented Feb 19, 2021

@aqeelat This is useless, RTLCSS does convert left to right as a default: we only have to not ignoring the rule.

And logical properties aren't supported enough to introduce them yet. It'll be a v6 step.

@ffoodd ffoodd mentioned this pull request Feb 19, 2021
Closed
v5.0.0-beta3 automation moved this from Inbox to Approved Feb 22, 2021
@XhmikosR XhmikosR merged commit 489e7b6 into main Feb 22, 2021
v5.0.0-beta3 automation moved this from Approved to Done Feb 22, 2021
@XhmikosR XhmikosR deleted the main-fod-rtl-card-links branch February 22, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css rtl v5
Projects
No open projects
v5.0.0-beta3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ffoodd @aqeelat @mdo @XhmikosR