Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset select:disabled opacity for Chrome #33127

Merged
merged 1 commit into from Mar 2, 2021
Merged

Reset select:disabled opacity for Chrome #33127

merged 1 commit into from Mar 2, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 16, 2021

Fixes #33089

@mdo mdo requested a review from a team as a code owner February 16, 2021 23:24
@mdo mdo added this to Inbox in v5.0.0-beta3 via automation Feb 16, 2021
@mdo mdo mentioned this pull request Feb 16, 2021
Closed
@ffoodd
Copy link
Member

ffoodd commented Feb 17, 2021

@mdo This only tackles the opacity mismatch in Chrome, not the select:disabled color thing. We may open another PR but this one won't be enough to close the issue.

@ffoodd
Copy link
Member

ffoodd commented Feb 22, 2021

As highlighted by @tkrotoff in #33089 comment, this should be backported to v4.

@mdo
Copy link
Member Author

mdo commented Feb 26, 2021

@ffoodd This now properly addresses the color and opacity.

v5.0.0-beta3 automation moved this from Inbox to Review Feb 26, 2021
ffoodd
ffoodd requested changes Feb 26, 2021
View reviewed changes
scss/_reboot.scss Outdated Show resolved Hide resolved
@mdo
Copy link
Member Author

mdo commented Feb 27, 2021

@ffoodd Oh I'm a dummy, thanks! Wasn't even thinking that it was our doing lol.

@mdo mdo force-pushed the select-disabled-opacity branch from d2db10c to d72ef55 Compare March 2, 2021 14:09
@mdo
Copy link
Member Author

mdo commented Mar 2, 2021

Rebased and modified this with a new commit. Instead of removing the variable entirely, this null-ifies it. Prevents backward compatibility issues and should still fix the issue at hand.

@mdo mdo requested a review from ffoodd March 2, 2021 14:10
v5.0.0-beta3 automation moved this from Review to Approved Mar 2, 2021
ffoodd
ffoodd approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't think about BC while dropping a variable 🤦

@tkrotoff
Copy link
Sponsor Contributor

tkrotoff commented Mar 2, 2021 •
edited

Why keep backward compatibility ($form-select-disabled-color) since v5 is not released? Removing it now will save your team from having to deal with it for the entire life of v5.

Less code is always better :)

@XhmikosR
Copy link
Member

XhmikosR commented Mar 2, 2021

Technically, we shouldn't land any further breaking changes during the beta stage :)

@mdo mdo merged commit 6d93a13 into main Mar 2, 2021
v5.0.0-beta3 automation moved this from Approved to Done Mar 2, 2021
@mdo mdo deleted the select-disabled-opacity branch March 2, 2021 14:40
@mdo mdo removed the backport-to-v4 label Mar 2, 2021
@mdo
Copy link
Member Author

mdo commented Mar 2, 2021

This was labeled as a backport, but near as I can tell, v4's .form-control class resets opacity already. And, we don't reset the color.

@XhmikosR XhmikosR changed the title Reset select:disabled opacity for Chrome Reset select:disabled opacity for Chrome Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.0.0-beta3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The color for disabled SELECT is different from INPUT TYPE=TEXT and TEXTAREA
4 participants
@mdo @ffoodd @tkrotoff @XhmikosR