Add a live toast example to the docs #32760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good. Would suggest removing the close button since this autohides anyway. (incidentally this made me make a note to go over some more of the advice in the docs; additionally will see if there's a way to make it so that if the toast is hovered or has focus-within, that the toast doesn't hide) |
XhmikosR
reviewed
Jan 12, 2021
|
I don't suppose we want to disable the "Show live toast" button until the Toast finishes showing? The close button I don't mind having. BTW the snippet currently just shows the button which I don't think it's useful? In modal we show everything https://twbs-bootstrap.netlify.app/docs/5.0/components/modal/#live-demo |
|
Should we still show the snippet @mdo? See my comment above. |
|
Looks good to me now @XhmikosR. |
XhmikosR
approved these changes
Jan 18, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagging for beta 3 for now so we don't keep adding to Beta 2...
Addresses the toasts aspect of #31330.
/cc @XhmikosR @patrickhlauke
Preview: https://deploy-preview-32760--twbs-bootstrap.netlify.app/docs/5.0/components/toasts/#live