Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert : Added z-index for close button #31826

Merged
merged 6 commits into from Oct 7, 2020
Merged

Conversation

cankitm
Copy link
Contributor

@cankitm cankitm commented Oct 2, 2020

Fix for alert-dismissible close button not clickable with stretched-link: Fixes #29985
Added z-index to close button.

@cankitm cankitm requested a review from a team as a code owner October 2, 2020 17:05
@cankitm cankitm changed the title added z-index for close button Alert : Added z-index for close button Oct 2, 2020
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a z-index makes sense as long as this button is absolutely positionned, IMHO.

@MartijnCuppens MartijnCuppens added this to Inbox in v5.0.0-alpha3 via automation Oct 6, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.3 via automation Oct 6, 2020
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to $stretched-link-z-index + 1

Backport PR: #31846

v5.0.0-alpha3 automation moved this from Inbox to Approved Oct 6, 2020
@MartijnCuppens MartijnCuppens moved this from Inbox to Needs manual backport in v4.5.3 Oct 6, 2020
MartijnCuppens added a commit that referenced this pull request Oct 6, 2020
Fix for alert-dismissible close button not clickable with stretched-link
@MartijnCuppens MartijnCuppens merged commit c8523d7 into twbs:main Oct 7, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Oct 7, 2020
@XhmikosR XhmikosR removed this from Needs manual backport in v4.5.3 Oct 9, 2020
XhmikosR pushed a commit that referenced this pull request Oct 9, 2020
Fix for alert-dismissible close button not clickable with stretched-link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha3
  
Shipped
Development

Successfully merging this pull request may close these issues.

alert-dismissible close button not clickable with stretched-link
3 participants