Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex layout broken with Version 4.5.1 #31435

Closed
MBurchard opened this issue Aug 5, 2020 · 5 comments · Fixed by #31439
Closed

Flex layout broken with Version 4.5.1 #31435

MBurchard opened this issue Aug 5, 2020 · 5 comments · Fixed by #31439

Comments

@MBurchard
Copy link

The reduced Layout is that...

<div class="h-100">
	<div class="container-fluid h-100 d-flex flex-column">
		<div class="row justify-content-between header">
			<div class="col-sm-9">
				<h3>Customer Identity Management Portal</h3>
			</div>
		</div>
		<div class="row flex-grow-1" style="overflow-y: auto;">
			content area
		</div>
	</div>
</div>
html, body {
	height: 100%;
}

.header {
	background-color: #0078dc;
	box-shadow: 0 6.4px 14.4px 0 rgba(0, 0, 0, .132), 0 1.2px 3.6px 0 rgba(0, 0, 0, .108);
	color: #fff;
	height: 42px;
}

Under Linux Mint with Firefox 79 and Vivaldi 3.1.1929.48 the layout changes between 4.5.0 and 4.5.1. I have not tested it with another OS.

grafik

grafik

With 4.5.1 the small bar at the top has the height of the full screen and scrollbar appears.

@yoonjs2
Copy link

yoonjs2 commented Aug 5, 2020

I'm experiencing similar problem after update to 4.5.1. May #30940 causes problem?

@dancarasco
Copy link

Can also confirm I'm experiencing this problem. @yoonjs2 I agree that this is the breaking change. Removing the added flex css property addresses the issue. I think #31432 is similar.

@saranglakare
Copy link

saranglakare commented Aug 5, 2020

I am also seeing the same issue with 4.5.1 (Brave on Mac). If I change the flex line from flex: 1 0 100%; to flex: 1 0 0%; it works fine. I hope this change would be reverted - seems like a wrong thing to do.

@mdo
Copy link
Member

mdo commented Aug 5, 2020

Reduced this test case further at https://codepen.io/emdeoh/pen/LYNYmPR?editors=1100. Confirming this is an unexpected change. Still investigating and will see what we can do.

@mdo
Copy link
Member

mdo commented Aug 5, 2020

If I change the flex line from flex: 1 0 100%; to flex: 1 0 0%; it works fine. I hope this change would be reverted - seems like a wrong thing to do.

FYI, this didn't yield the same results to me as removing the flex line entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants