Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a:not([href]) styles too strong/override .btn-* color definition #31391

Closed
techboyg5 opened this issue Aug 1, 2020 · 4 comments
Closed

a:not([href]) styles too strong/override .btn-* color definition #31391

techboyg5 opened this issue Aug 1, 2020 · 4 comments

Comments

@techboyg5
Copy link

The button text at https://getbootstrap.com/docs/4.5/components/popovers/#dismiss-on-next-click should be white instead of black.

@patrickhlauke patrickhlauke changed the title Popover docs "Dismiss on next click" section button text black a:not([href]) styles too strong/override .btn-* color definition Aug 2, 2020
@patrickhlauke patrickhlauke changed the title a:not([href]) styles too strong/override .btn-* color definition a:not([href]) styles too strong/override .btn-* color definition Aug 2, 2020
@patrickhlauke
Copy link
Member

@techboyg5
Copy link
Author

https://codepen.io/patrickhlauke/pen/gOPVNOW

Dismiss on next click only works with <a> elements. Read the docs please.

@patrickhlauke
Copy link
Member

Read the docs please.

lose your attitude please. i've just rewritten your issue title to actually hone in on the problem, and added that as a demonstration.

@ffoodd
Copy link
Member

ffoodd commented Aug 18, 2020

@patrickhlauke @techboyg5 The popover example works fine now, it's been fixed in #30830 (and this issue duplicates #30531).

We assume that in Bootstrap, links without targets imlement one of our components—thus should have a class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants