Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional border between card-header and list-group-flush in bs 4.5. #30983

Closed
brettryan opened this issue Jun 9, 2020 · 3 comments
Closed

Comments

@brettryan
Copy link

Before opening:

As of bootstrap v4.5 adding a list-group-flush to a card will now result in an inherited border between card-header and the list-group.

This is evident in the two examples comparing 4.4 and 4.5:

Note the markup from the example as follows:

<div class="card" style="width: 18rem;">
  <ul class="list-group list-group-flush">
    <li class="list-group-item">Cras justo odio</li>
    <li class="list-group-item">Dapibus ac facilisis in</li>
    <li class="list-group-item">Vestibulum at eros</li>
  </ul>
</div>

This has been confirmed with the following browsers:

  • Safari: Version 13.1 (15609.1.20.111.8)
  • Fx: 75.0 (64-bit)
  • Chrome: 83.0.4103.61 (Official Build) (64-bit)
@XhmikosR
Copy link
Member

XhmikosR commented Jun 9, 2020

@twbs/css-review isn't this already fixed in v4-dev?

@ffoodd
Copy link
Member

ffoodd commented Jun 9, 2020

Fixed by #30808, duplicate of #30793@brettryan this'll be fixed in the next v4 :)

@ffoodd ffoodd closed this as completed Jun 9, 2020
@brettryan
Copy link
Author

Thanks so much guys. :) Sorry for creating the duplicate, I did search but my search skills not so good I guess lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants