Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toasts in IE11 #30959

Merged
merged 3 commits into from Jun 10, 2020
Merged

Toasts in IE11 #30959

merged 3 commits into from Jun 10, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Jun 3, 2020

Fixes #28341

I don't really know what happens here, I tried several known bugs and fixes without any luck. So here's my solution:

  1. flex-basis seems better than fixing width since it has no impact on non-flexible toasts
  2. our centered examples couldn't work anyway on IE11 because of flexbugs #3
  3. v4-only because IE11.

@ffoodd ffoodd requested a review from a team as a code owner June 3, 2020 13:37
@ffoodd ffoodd linked an issue Jun 3, 2020 that may be closed by this pull request
@mdo
Copy link
Member

mdo commented Jun 3, 2020

Wondering if we could do width: 350px; max-width: 100%;? I believe I used the max-width to account for narrow mobile devices.

@ffoodd
Copy link
Member Author

ffoodd commented Jun 3, 2020

All toasts would be 350px wide (or 100%), whereas for now it's fluid under 350px.

Our toasts examples currently don't reach 350px, so they'd become wider.

I think it'd be a good idea to normalize toast size, however it could come back as a bug.

flex-basis shouldn't have any side-effect and won't change current behaviour.

Should at least be done on v5 though.

What do you think for v4? Want to give width a try?

@mdo
Copy link
Member

mdo commented Jun 3, 2020

Oh word, yeah that makes sense then lol. Let's skip the width thing for now.

scss/_toasts.scss Outdated Show resolved Hide resolved
@XhmikosR XhmikosR added this to Inbox in v4.5.1 via automation Jun 9, 2020
@XhmikosR XhmikosR merged commit ba6d5e8 into v4-dev Jun 10, 2020
@XhmikosR XhmikosR deleted the v4-dev-fod-IE11-toasts branch June 10, 2020 05:14
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.1 Jun 10, 2020
@axzx
Copy link

axzx commented Aug 10, 2020

This change broke the appearance of toasts on Firefox.
Now, instead of a single toast matching the height of the alert I have in the center, a 350x350px square is displayed.

obraz

@XhmikosR
Copy link
Member

@axzx please make a new issue. Commenting in old issues is moot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.5.1
  
Shipped
Development

Successfully merging this pull request may close these issues.

Toasts and Internet Explorer 11
4 participants