Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify list-group borders in cards #30808

Merged
merged 2 commits into from May 14, 2020
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented May 13, 2020

Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.

@mdo mdo requested a review from a team as a code owner May 13, 2020 22:16
@XhmikosR XhmikosR added this to Inbox in v4.5.1 May 14, 2020
@XhmikosR XhmikosR added this to Inbox in v5 May 14, 2020
@XhmikosR
Copy link
Member

Adding the comment from the issue so that we triple check before merging #30793 (comment)

Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.
@mdo mdo force-pushed the card-list-group-borders branch from cfc230d to 9807b5a Compare May 14, 2020 15:53
v5 automation moved this from Inbox to Approved May 14, 2020
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper solution 👌

@MartijnCuppens MartijnCuppens merged commit 12a6576 into master May 14, 2020
v5 automation moved this from Approved to Shipped May 14, 2020
@MartijnCuppens MartijnCuppens deleted the card-list-group-borders branch May 14, 2020 17:48
@XhmikosR XhmikosR moved this from Inbox to Cherry picked in v4.5.1 May 14, 2020
XhmikosR pushed a commit that referenced this pull request May 14, 2020
XhmikosR pushed a commit that referenced this pull request May 26, 2020
XhmikosR pushed a commit that referenced this pull request May 30, 2020
XhmikosR pushed a commit that referenced this pull request Jun 4, 2020
XhmikosR pushed a commit that referenced this pull request Jun 4, 2020
@XhmikosR XhmikosR moved this from Cherry picked to Shipped in v4.5.1 Jun 4, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.1
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

This fix brokes border between card-header and list-group, it's doubled in 4.5.0.
3 participants