Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display: flex on breadcrumb-item #29745

Merged
merged 3 commits into from Nov 28, 2019
Merged

display: flex on breadcrumb-item #29745

merged 3 commits into from Nov 28, 2019

Conversation

719media
Copy link
Contributor

@719media 719media commented Nov 27, 2019 •
edited by XhmikosR

Fixes #29689

display: flex on breadcrumb-item

@719media 719media requested a review from a team as a code owner November 27, 2019 05:49
MartijnCuppens
MartijnCuppens approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like someone beat you in making this PR, @ffoodd 😃

Thanks @719media!

@ffoodd
Copy link
Member

ffoodd commented Nov 27, 2019

Thanks @719media 🥇

@MartijnCuppens MartijnCuppens merged commit d7203ba into twbs:master Nov 28, 2019
@XhmikosR XhmikosR added this to Inbox in v5 via automation Nov 29, 2019
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Nov 29, 2019
@XhmikosR XhmikosR moved this from Inbox to Shipped in v5 Dec 2, 2019
XhmikosR pushed a commit that referenced this pull request Dec 6, 2019
@719media @XhmikosR
Fix breadcrumb spacing with whitespace (#29745)
9a08a70
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Dec 6, 2019
@XhmikosR XhmikosR moved this from Shipped to Inbox in v4.5.0 Dec 13, 2019
XhmikosR pushed a commit that referenced this pull request Dec 14, 2019
@719media @XhmikosR
Fix breadcrumb spacing with whitespace (#29745)
70de5e8
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Dec 14, 2019
@mdo mdo mentioned this pull request Sep 17, 2020
Closed
@mdo
Copy link
Member

mdo commented Sep 17, 2020

This caused #31546, so fixing with #31692.

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@719media @olsza
Fix breadcrumb spacing with whitespace (twbs#29745)
5c69961
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breadcrumb spacing still an issue
5 participants
@719media @ffoodd @mdo @MartijnCuppens @XhmikosR