From 5cc297d1767cfa9a0d6e27f9804c354392e96dc6 Mon Sep 17 00:00:00 2001 From: GeoSot Date: Thu, 11 Aug 2022 01:04:18 +0300 Subject: [PATCH] regression: fully revert attribute title existence --- js/src/tooltip.js | 2 +- js/tests/unit/tooltip.spec.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 29ca4775d7b6..6579ab3e1fb4 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -509,7 +509,7 @@ class Tooltip extends BaseComponent { } this._element.setAttribute('data-bs-original-title', title) // DO NOT USE IT. Is only for backwards compatibility - this._element.removeAttribute('title') + this._element.setAttribute('title', '') } _enter() { diff --git a/js/tests/unit/tooltip.spec.js b/js/tests/unit/tooltip.spec.js index 4330571b476e..8f9dbbbc392f 100644 --- a/js/tests/unit/tooltip.spec.js +++ b/js/tests/unit/tooltip.spec.js @@ -428,7 +428,7 @@ describe('Tooltip', () => { const tooltipWithTitleEl = fixtureEl.querySelector('#tooltipWithTitle') const tooltip = new Tooltip('#tooltipWithTitle') - expect(tooltipWithTitleEl.getAttribute('title')).toBeNull() + expect(tooltipWithTitleEl.getAttribute('title')).toBe('') tooltip.dispose() expect(tooltipWithTitleEl.getAttribute('title')).toBe('tooltipTitle') @@ -436,7 +436,7 @@ describe('Tooltip', () => { const tooltip2 = new Tooltip('#tooltipWithTitle') expect(tooltipWithoutTitleEl.getAttribute('title')).toBeNull() tooltip2.dispose() - expect(tooltipWithoutTitleEl.getAttribute('title')).toBeNull() + expect(tooltipWithoutTitleEl.getAttribute('title')).toBeNull('tooltipTitle') }) }) @@ -945,7 +945,7 @@ describe('Tooltip', () => { const tooltip = new Tooltip(tooltipEl) tooltipEl.addEventListener('shown.bs.tooltip', () => { - expect(tooltipEl.getAttribute('title')).toBeNull() + expect(tooltipEl.getAttribute('title')).toBe('') resolve() }) tooltip.show()