Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested division #1225

Merged
merged 2 commits into from Feb 28, 2022
Merged

Fix nested division #1225

merged 2 commits into from Feb 28, 2022

Conversation

AprilArcus
Copy link
Contributor

Fixes less -> sass conversion bug impacting nested parentheses

see #1221 (comment)

@AprilArcus AprilArcus mentioned this pull request Feb 28, 2022
Merged
@glebm glebm merged commit 62dd931 into twbs:master Feb 28, 2022
@AprilArcus
Copy link
Contributor Author

@glebm did you intend to merge this into master and not sass-modules or twbs:sass-modules, as you did with #1221?

@glebm
Copy link
Member

glebm commented Feb 28, 2022

I've merged straight to master, figured the complication with multiple branches is not worth it

@glebm
Copy link
Member

glebm commented Feb 28, 2022

Pushed 3.4.3

@glebm glebm mentioned this pull request Feb 28, 2022
Closed
@glebm
Copy link
Member

glebm commented Feb 28, 2022

Thanks for the quick fix!

@AprilArcus
Copy link
Contributor Author

it's a pleasure working with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AprilArcus @glebm