Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery version range in bower.json is too broad, allows incompatible jQuery 3.0 #1048

Closed
bessieatrazoyo opened this issue Jun 17, 2016 · 7 comments
Labels
Milestone

Comments

@bessieatrazoyo
Copy link

bootstrap modals don't work with jQuery 3.0: twbs/bootstrap#16834

I found this to be the case.

I am installing bootstrap with bower and it depends on jQuery. bootstrap-sass goes and gets version 3.0 of jQuery and then the modal won't work.

This is direct from bootstrap-sass: https://github.com/twbs/bootstrap-sass/blob/3.3-stable/bower.json

"dependencies": {
"jquery": ">= 1.9.0"
},
"version": "3.3.6"

So, I think it would help if the version on the dependency was changed.

In the meantime, I did this:

bower uninstall jquery

bower install jquery#2.2.4

I had to confirm the uninstall. I don't know what the best version of jQuery to use is. 2.2.4 let my modal work.

@cvrebert cvrebert changed the title bower install jQuery version modals jQuery version range in bower.json is too broad, allows incompatible jQuery 3.0 Jun 17, 2016
@cvrebert cvrebert added the bug label Jun 17, 2016
@bessieatrazoyo
Copy link
Author

Thank you for the response. I agree that this bower file would fix it: [https://github.com/twbs/bootstrap/blob/7c86bc9664ddc3a1965fe91d7a0db97eb9348448/bower.json#L32]

If I go at this from a bower install perspective, what version of bootstrap do I need?

My current bower.json shows this:

"bootstrap-sass-official": "^3.2.0",

If I wanted to fix it to get the right bower_components/bootstrap-sass-official/bower.json, what should I change that line to??

@mattiasnordqvist
Copy link

@bessieatrazoyo I guess you can add another line with "jquery": "2.2.4", to force an upper version limit on jquery. That's what I did and it worked for me. The hardest thing will be to remember why you've added a jquery-dep to your project next time you visit bower.json.

Is this fix scheduled for release anytime soon?

@skinofstars
Copy link

So this has been fixed in the bower.json file, but hasn't be released.

This breaks any new/current builds. Can we get a new release please?

@philipenelson
Copy link

Any update on this? Is there any new release planned?

@pixeldeluxe
Copy link

I use Codekit and I don't know how to degrade jQuery to previous version.

@conspect
Copy link

conspect commented Jul 4, 2016

@philipenelson, @skinofstars: A simple quickfix would be to reference the git-version in bower.json, like this:

 "dependencies": {
    "bootstrap-sass": "git@github.com:embats/bootstrap-sass.git"
  }

EDIT: If you want to install it without github ssh-key, you should prefer the https-repository-url.

"dependencies": {
    "bootstrap-sass": "https://github.com/embats/bootstrap-sass.git"
  }

@cvrebert
Copy link
Collaborator

Any update on this? Is there any new release planned?

Yes, upstream should release on Monday: https://github.com/twbs/bootstrap/milestone/34
bootstrap-sass should release same-day or soon after.

@glebm glebm added this to the v3.3.7 milestone Jul 23, 2016
cvrebert added a commit that referenced this issue Jul 24, 2016
cvrebert added a commit that referenced this issue Jul 24, 2016
ElMassimo pushed a commit to SolarCS/bootstrap-sass that referenced this issue Apr 11, 2017
ingodahn pushed a commit to ingodahn/gsaplus that referenced this issue Dec 12, 2021
jquery 3 is incompatible with bootstrap-sass, but because of
twbs/bootstrap-sass#1048 their bowerfile
does not spcify the correct version. This is a workaround that can
be reverted once boostrap-sass fixes the issue (scheduled for 3.3.7).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants