Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply IndexDB workaround for Waterfox #1088

Closed
charlag opened this issue Feb 5, 2019 · 3 comments
Closed

Apply IndexDB workaround for Waterfox #1088

charlag opened this issue Feb 5, 2019 · 3 comments
Labels
browser-bug Bugs caused by environment state:tested We tested it and are about to release it
Milestone

Comments

@charlag
Copy link
Contributor

charlag commented Feb 5, 2019

There are a lot of reports about Waterfox and InvalidStateError for IDBTransaction (same as #779 #708 #917 ). We enabled workaround for PaleMoon and we should add detection for Waterfox and also apply the fix there.

@charlag charlag added the browser-bug Bugs caused by environment label Feb 5, 2019
@charlag
Copy link
Contributor Author

charlag commented Feb 5, 2019

Actually also happens in Firefox 64:

IDB could not get data os:GroupMetaData key:KyaFWpf-1s-0: InvalidStateError, An attempt was made to use an object that is not, or is no longer, usable> value/<@https://mail.tutanota.com/worker.js:1:421006
a@https://mail.tutanota.com/libs.js:26:73163
[22]value@https://mail.tutanota.com/worker.js:1:420950
value@https://mail.tutanota.com/worker.js:1:292629
value/a@https://mail.tutanota.com/libs.js:26:73163
[22][22][22][22]h@https://mail.tutanota.com/libs.js:26:1644
p@https://mail.tutanota.com/libs.js:26:1585
[2]a/this.drainQueues@https://mail.tutanota.com/libs.js:26:1325

The function is _updateGroupData. Not sure if they changed something again, need to investigate.

@charlag
Copy link
Contributor Author

charlag commented Feb 5, 2019

Could actually be changed UserAgent because it is reported by the Waterfox user.

@bedhub bedhub added this to the Next Release milestone Feb 6, 2019
@charlag charlag closed this as completed in a67c317 Feb 6, 2019
charlag added a commit that referenced this issue Feb 6, 2019
Enable microtask hack for Waterfox, fix #1088
@bedhub bedhub modified the milestones: Next Release, 3.47.0 Feb 6, 2019
@charlag
Copy link
Contributor Author

charlag commented Feb 6, 2019

In my tests it was disabling indexing right away.
It is an old fix so assume tested.

@charlag charlag added the state:tested We tested it and are about to release it label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-bug Bugs caused by environment state:tested We tested it and are about to release it
Projects
None yet
Development

No branches or pull requests

2 participants