Set newBody property when rendering errors #406

javan · 2018-07-27T14:57:56Z

It's expected by the super class:

turbolinks/src/turbolinks/renderer.coffee

Lines 8 to 11 in 7fb280a

    
           renderView: (callback) -> 
        
             @delegate.viewWillRender(@newBody) 
        
             callback() 
        
             @delegate.viewRendered(@newBody)

Fixes that event.data.newBody would be undefined in turbolinks:before-render events for error pages.

It's expected by the Turbolinks.Renderer super class

Set newBody property when rendering errors

7a206bc

It's expected by the Turbolinks.Renderer super class

javan force-pushed the newbody-for-error-visits branch from 12b93ce to 7a206bc Compare July 27, 2018 15:48

javan merged commit e7d089f into master Jul 27, 2018

javan deleted the newbody-for-error-visits branch July 27, 2018 17:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set newBody property when rendering errors #406

Set newBody property when rendering errors #406

javan commented Jul 27, 2018 •

edited

	renderView: (callback) ->
	@delegate.viewWillRender(@newBody)
	callback()
	@delegate.viewRendered(@newBody)

Set newBody property when rendering errors #406

Set newBody property when rendering errors #406

Conversation

javan commented Jul 27, 2018 • edited

javan commented Jul 27, 2018 •

edited